Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe): resolve 504 timeout error in vercel #1251

Merged
merged 28 commits into from
Feb 1, 2024
Merged

Conversation

dotoleeoak
Copy link
Member

@dotoleeoak dotoleeoak commented Jan 24, 2024

Description

API가 fetch 되는 동안 Suspense로 화면에 fallback을 보여줍니다.

2024-01-31.8.15.13.mov

Additional context

  • fetch(kv)에 timeout을 5초로 설정하였습니다.
  • TimeDiff 컴포넌트에서 처음 렌더링 시 시간이 '0'으로 표시되는 문제를 해결했습니다.

Before submitting the PR, please make sure you do the following

@dotoleeoak dotoleeoak self-assigned this Jan 24, 2024
Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Feb 1, 2024 5:50am

@dotoleeoak dotoleeoak added 🪰 bug Something isn't working ⛳️ team-frontend labels Jan 31, 2024
@dotoleeoak dotoleeoak requested a review from dayongkr January 31, 2024 11:19
@dotoleeoak dotoleeoak marked this pull request as ready for review January 31, 2024 11:37
@dayongkr
Copy link
Contributor

dayongkr commented Feb 1, 2024

build시에 next-auth.d.ts 파일을 생성하기 때문에 해당 파일이 없을 때 type check했던 부분은 빼는게 맞을 것 같은데 bulid시 lint 작업은 수행하는 게 맞는 것 같아서 수정했습니다!

추가로 image.d.ts 파일 필요 없는데 제가 이전에 모르고 추가해놔서 삭제했습니다!

@dotoleeoak dotoleeoak merged commit 6f769b0 into main Feb 1, 2024
11 checks passed
@dotoleeoak dotoleeoak deleted the nextjs-vercel-504-debug branch February 1, 2024 06:31
cho-to pushed a commit that referenced this pull request Feb 5, 2024
* chore: remove header from main layout

* feat: remove api call from main page

* feat: add header again

* feat: try api call with timeout 3s

* feat: log response time

* feat: use node-fetch

* feat: log fetching timing

* feat: use axios

* feat: disable standalone output

* feat: use nextjs fetch

* feat: use suspense component

* feat: add problem cards

* fix: remove unused component

* feat: use skeleton while waiting for API response

* feat: set API fetch timeout to 5 seconds

* fix: do not show zero time diff

* feat: add error page for timeout

* feat: add loading fallback in notice page

* feat: add loading fallback in problem list page

* fix: ignore timediff hydration warning

* feat: adjust error message width

* feat: add loading fallback in contest page

* fix: resolve build error

* feat(ci): disable linting on nexjts build

* fix(ci): do not perform typecheck for frontend-client

Check: vercel/next.js#53959

* feat(fe): remove images.dt.s

---------

Co-authored-by: Dayong Lee <dayongkr@gmail.com>
cho-to pushed a commit that referenced this pull request Feb 5, 2024
* chore: remove header from main layout

* feat: remove api call from main page

* feat: add header again

* feat: try api call with timeout 3s

* feat: log response time

* feat: use node-fetch

* feat: log fetching timing

* feat: use axios

* feat: disable standalone output

* feat: use nextjs fetch

* feat: use suspense component

* feat: add problem cards

* fix: remove unused component

* feat: use skeleton while waiting for API response

* feat: set API fetch timeout to 5 seconds

* fix: do not show zero time diff

* feat: add error page for timeout

* feat: add loading fallback in notice page

* feat: add loading fallback in problem list page

* fix: ignore timediff hydration warning

* feat: adjust error message width

* feat: add loading fallback in contest page

* fix: resolve build error

* feat(ci): disable linting on nexjts build

* fix(ci): do not perform typecheck for frontend-client

Check: vercel/next.js#53959

* feat(fe): remove images.dt.s

---------

Co-authored-by: Dayong Lee <dayongkr@gmail.com>
cho-to pushed a commit that referenced this pull request Feb 19, 2024
* chore: remove header from main layout

* feat: remove api call from main page

* feat: add header again

* feat: try api call with timeout 3s

* feat: log response time

* feat: use node-fetch

* feat: log fetching timing

* feat: use axios

* feat: disable standalone output

* feat: use nextjs fetch

* feat: use suspense component

* feat: add problem cards

* fix: remove unused component

* feat: use skeleton while waiting for API response

* feat: set API fetch timeout to 5 seconds

* fix: do not show zero time diff

* feat: add error page for timeout

* feat: add loading fallback in notice page

* feat: add loading fallback in problem list page

* fix: ignore timediff hydration warning

* feat: adjust error message width

* feat: add loading fallback in contest page

* fix: resolve build error

* feat(ci): disable linting on nexjts build

* fix(ci): do not perform typecheck for frontend-client

Check: vercel/next.js#53959

* feat(fe): remove images.dt.s

---------

Co-authored-by: Dayong Lee <dayongkr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪰 bug Something isn't working ⛳️ team-frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants