-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fe): resolve 504 timeout error in vercel #1251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
build시에 next-auth.d.ts 파일을 생성하기 때문에 해당 파일이 없을 때 type check했던 부분은 빼는게 맞을 것 같은데 bulid시 lint 작업은 수행하는 게 맞는 것 같아서 수정했습니다! 추가로 image.d.ts 파일 필요 없는데 제가 이전에 모르고 추가해놔서 삭제했습니다! |
dayongkr
approved these changes
Feb 1, 2024
cho-to
pushed a commit
that referenced
this pull request
Feb 5, 2024
* chore: remove header from main layout * feat: remove api call from main page * feat: add header again * feat: try api call with timeout 3s * feat: log response time * feat: use node-fetch * feat: log fetching timing * feat: use axios * feat: disable standalone output * feat: use nextjs fetch * feat: use suspense component * feat: add problem cards * fix: remove unused component * feat: use skeleton while waiting for API response * feat: set API fetch timeout to 5 seconds * fix: do not show zero time diff * feat: add error page for timeout * feat: add loading fallback in notice page * feat: add loading fallback in problem list page * fix: ignore timediff hydration warning * feat: adjust error message width * feat: add loading fallback in contest page * fix: resolve build error * feat(ci): disable linting on nexjts build * fix(ci): do not perform typecheck for frontend-client Check: vercel/next.js#53959 * feat(fe): remove images.dt.s --------- Co-authored-by: Dayong Lee <dayongkr@gmail.com>
cho-to
pushed a commit
that referenced
this pull request
Feb 5, 2024
* chore: remove header from main layout * feat: remove api call from main page * feat: add header again * feat: try api call with timeout 3s * feat: log response time * feat: use node-fetch * feat: log fetching timing * feat: use axios * feat: disable standalone output * feat: use nextjs fetch * feat: use suspense component * feat: add problem cards * fix: remove unused component * feat: use skeleton while waiting for API response * feat: set API fetch timeout to 5 seconds * fix: do not show zero time diff * feat: add error page for timeout * feat: add loading fallback in notice page * feat: add loading fallback in problem list page * fix: ignore timediff hydration warning * feat: adjust error message width * feat: add loading fallback in contest page * fix: resolve build error * feat(ci): disable linting on nexjts build * fix(ci): do not perform typecheck for frontend-client Check: vercel/next.js#53959 * feat(fe): remove images.dt.s --------- Co-authored-by: Dayong Lee <dayongkr@gmail.com>
cho-to
pushed a commit
that referenced
this pull request
Feb 19, 2024
* chore: remove header from main layout * feat: remove api call from main page * feat: add header again * feat: try api call with timeout 3s * feat: log response time * feat: use node-fetch * feat: log fetching timing * feat: use axios * feat: disable standalone output * feat: use nextjs fetch * feat: use suspense component * feat: add problem cards * fix: remove unused component * feat: use skeleton while waiting for API response * feat: set API fetch timeout to 5 seconds * fix: do not show zero time diff * feat: add error page for timeout * feat: add loading fallback in notice page * feat: add loading fallback in problem list page * fix: ignore timediff hydration warning * feat: adjust error message width * feat: add loading fallback in contest page * fix: resolve build error * feat(ci): disable linting on nexjts build * fix(ci): do not perform typecheck for frontend-client Check: vercel/next.js#53959 * feat(fe): remove images.dt.s --------- Co-authored-by: Dayong Lee <dayongkr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
API가 fetch 되는 동안 Suspense로 화면에 fallback을 보여줍니다.
2024-01-31.8.15.13.mov
Additional context
Before submitting the PR, please make sure you do the following
fixes #123
).