feat(fe): add register code dialog, split register logic based on invitationCodeExists #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itationCodeExists
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jihorobert
pushed a commit
that referenced
this pull request
Jul 28, 2024
…itationCodeExists (#1835) * feat(fe): add register code dialog, split register logic based on invitationCodeExists * chore: change register code to invitation code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deregister 로직을 주석처리하고, 초대 코드 입력 모달을 구현했습니다.
Register.Code.Dialog.mp4
1. Upcoming Contest
Register Now 버튼이 비활성화됩니다.
2. 초대코드가 없는 Ongoing Contest
Register Now 버튼을 통해 바로 등록 가능합니다.
3. 초대코드가 있는 Ongoing Contest
Register Now 버튼을 통해 초대코드 입력 모달을 열고
모달에 올바른 초대코드를 입력하는 것으로 대회에 등록합니다.
참고사항
모달에 초대코드 입력할 때 경고 문구를
'Register Code must be a 6-digit number'로 설정했습니다.
피그마의 경우 'Incorrect'로 되어 있으나,
초대코드의 형식과 값 중 어느 것이 틀린 것인지 혼동 될 걸 우려해 수정했습니다.
추가 변경 사항 (7/22)
로컬 스토리지에 초대코드가 저장될 수 있도록 수정했습니다.
(이전에 초대코드 관련 Admin 개발할 때 깜빡했었습니다...)
Closes #1811
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).