-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fe): prevent send email button disable #1980
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoojin9
requested review from
dayongkr,
jihorobert,
juhyeong0505,
B0XERCAT,
youznn and
Kimhyojung0810
August 19, 2024 17:53
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
B0XERCAT
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
아이콘이 Image인 경우 width 속성으로 조절할 수 있습니다!
아 그런가요? width도 뭐 어떻게 건드려보긴 했던 거 같은데 잘 안 됐어서... 일단 대충 맞는 것 같으니 머지하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
이메일 전송 버튼을 광클하는 문제를 막기 위해 추가한 disable 기능이 이메일 필드 값 자체에 문제가 있을 시 다시 enable되지 않는 버그 수정
signup 들어가자마자 unavailable 뜨던 문제 해결
TAS-697의 캡션 정렬(원래 Input의 ring을 건드리던 걸 border를 건드리도록 바꿈)/버튼 사이즈 수정
소소한 회원가입 문구 수정
(적어놓고 나니 한 PR에서 너무 많은 걸 수정해버린 듯...ㅋㅋㅋㅋㅠㅠ)
closes TAS-723
closes TAS-741
closes TAS-742
Additional context
버튼 안에 있는 아이콘 크기 조절이 마음대로 잘 안 되서 최대한 비슷하게 하긴 했는데 어떻게 조절하는 건지 잘 모르겠네요...
Before submitting the PR, please make sure you do the following
fixes #123
).