feat(fe): show modal when leaving create and edit page #2031
Conversation
* feat(be): add contest-submission-result model * chore(be): rename contest-submission-result to contest-submission-information * chore(be): set nullability of fields in contest-submission-information * feat(be): add get-contest-submission-informations api * chore(be): rename * test(be): add test * docs(be): add docs * chore(be): rename files and add fields on contest-submission-summary-for-one * feat(be): implement combine score summary and submissions * chore(be): comment test * feat(be): add problem-id option * fix(be): fix wrong type * docs(be): rename files * docs(be): rename file * docs(be): rename files * fix(be): fix ContestSubmissionSummaryForOne model * docs(be): remove resolved todo * chore(be): lint contest.service.spec * fix(be): don't throw error when no submission --------- Co-authored-by: 강민석 <min.seok@g.skku.edu> Co-authored-by: jimin9038 <jimin9038@g.skku.edu>
* feat(infra): add capacity provider strategy to ecs cluster * feat(infra): modify weight of capacity provider strategy to 1
* feat(fe): edit popover text and padding * chore(fe): add space between title and visible, add left margin to angleleft * chore(fe): add color to radio button, adjust gaps * feat(fe): change checkbox design, delete tag select, change box order * chore(fe): change toggle color, move template field * chore(fe): move title, add space between title and visible, move template up hint and source * fix(fe): comment out tags and get tag * chore(fe): delete comment about tag feature * chore(fe): delete comments * chore(fe): delete comments --------- Co-authored-by: Jiho Park <59248080+jihorobert@users.noreply.github.com>
Co-authored-by: Jiho Park <59248080+jihorobert@users.noreply.github.com>
* feat(be): implement getContestScoreSummaries * fix(be): make userContestScoreSummaryWithUserInfo model to return user * docs(be): getcontestscoresummaries * fix(be): rename get contest score api
* feat(be): delete example-io and add is-hidden-testcase field * feat(be): modify get-problem api to return testcases * docs(be): add is-hidden-testcase * fix(be): rename variable name of problem-response * docs(be): add problem-testcase field * docs(be): add todo on create-testcases - TODO: 테스트케이스 저장 방식 S3 => DB 직접 저장으로 변경 시 함수 삭제 * chore(be): change is-hidden-testcase to is-hidden * fix(fe): erase sample in admin, change samples to problem testcase in client --------- Co-authored-by: b0xercat <seojin3154@naver.com> Co-authored-by: jimin9038 <jimin9038@g.skku.edu>
jwoojin9
added
⛳️ team-frontend
💡 feature-admin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
아 build frontend 에서 뜨는 에러 확인부탁드려요! |
수정하고 컴포넌트화도 시켰습니다! 에러 없으면 머지할게요!! |
|
머지하려고 했는데... 큰 문제가 있네요 원래 create할 때 경고가 안 떴는데 컴포넌트화하니까 뜨네요... 좀 더 수정해볼게요! |
혹시 컴포넌트에서도 useRef 써서하면 해결되려나..?? |
어어 좀 전에 그렇게 하니까 해결됐어! 👍 |
굳굳 |
Description
problem이나 contest를 create할 때 확인 모달을 띄우도록 하였습니다! 때문에 기존 create 버튼을 누르면 유효성 검사를 먼저 하고, 유효성 검사가 완료됐을 때 모달을 띄워 확인 버튼을 눌렀을 때 create하도록 분리하였습니다!
problem이나 contest create/edit 창에서 이탈할 때 확인 모달을 띄우도록 하였습니다!(뒤로가기를 눌렀을 때도 하고 싶었는데 불가능한 것 같더라고요....) 여러 문제점을 고려해 커스텀이 아닌 기본 모달을 사용하기로 결정하였습니다..!
closes TAS-793
closes TAS-794
closes TAS-795
closes TAS-796
Additional context
rebase를 하다가 뭔가를 건드린 거 같긴 한데 잘 모르겠네요... 문제 없겠죠..?
우연히 console을 보다가 발견했는데 ssr 관련 warning이 나더라고요?? 좀 찾아봤는데 뭐 때문인지 잘 모르겠고 기능에는 문제가 없는 것 같아 일단 냅뒀는데 리뷰하시면서 문제 찾으면 알려주세요..!
Before submitting the PR, please make sure you do the following
fixes #123).