Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): edit client contest list and table #2043

Merged
merged 8 commits into from
Aug 31, 2024
Merged

Conversation

youznn
Copy link
Member

@youznn youznn commented Aug 30, 2024

Description

Contest Editor에서 badge를 숨겼습니다.
Contest List 작업 완료했습니다.

  1. isRegistered && isJudgeResultVisible인 경우입니다.
image
  1. isRegistered && !isJudgeResultVisible인 경우입니다.
image score부분은 백엔드 수정되면 자동으로 빈칸으로 바뀔 예정이에요
  1. !isRegistered인 경우입니다.
image total score를 보여주지 않음

Additional context

현재 register 버튼 클릭 이후 뒤로가기 눌렀을 때 버튼 업데이트가 되지 않는 오류 발생 -> router.refresh()를 삭제했던 걸 다시 살려 줬습니다.
table 부분은 백엔드 작업 완료되면 다시 진행할게요

close TAS-555
close TAS-826
close TAS-804
close TAS-554
close TAS-553


Before submitting the PR, please make sure you do the following

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Aug 31, 2024 4:13am

@jimin9038
Copy link
Member

대회 점수는 문제 점수의 합으로 프론트에서 구현가능할까요? 현재 백엔드 구현상 isJudgeResultVisible에 무관하게 점수가 반환되는데, 이부분은 오늘 안에 백엔드 고칠게요.

@youznn
Copy link
Member Author

youznn commented Aug 30, 2024

대회 점수는 문제 점수의 합으로 프론트에서 구현가능할까요? 현재 백엔드 구현상 isJudgeResultVisible에 무관하게 점수가 반환되는데, 이부분은 오늘 안에 백엔드 고칠게요.

넵알겠습니다...!!

Copy link
Contributor

@jihorobert jihorobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 수고하셨어요~

@youznn youznn merged commit 87d4ecf into main Aug 31, 2024
9 checks passed
@youznn youznn deleted the t547-edit-client-contest branch August 31, 2024 04:24
Copy link

Copy link

Copy link

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

3 participants