Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe): longer contest timer toast #2073

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jimin9038
Copy link
Member

@jimin9038 jimin9038 commented Sep 5, 2024

Description

contest timer toast duration을 10초로 늘립니다.
원래는 2초가 기본값이지만, 옵션으로 인자를 넘겨서 default값을 오버라이드합니다.

closes TAS-853

Additional context


Before submitting the PR, please make sure you do the following

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
codedang ✅ Ready (Inspect) Visit Preview Sep 5, 2024 8:12am

@jimin9038 jimin9038 requested review from B0XERCAT, youznn and jwoojin9 and removed request for youznn September 5, 2024 08:07
@jimin9038 jimin9038 self-assigned this Sep 5, 2024
Copy link

Copy link
Member

@B0XERCAT B0XERCAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@jimin9038 jimin9038 merged commit 093492b into main Sep 9, 2024
20 of 21 checks passed
@jimin9038 jimin9038 deleted the t853-longer-contest-timer-toast branch September 9, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants