fix(be): check if admin when get submissions

apps/backend/apps/client/src/submission/submission.controller.ts

@@ -13,7 +13,10 @@ import {
   Headers
 } from '@nestjs/common'
 import { Prisma } from '@prisma/client'
-import { AuthNotNeededIfOpenSpace, AuthenticatedRequest } from '@libs/auth'
+import {
+  AuthenticatedRequest,
+  UserNullWhenAuthFailedIfOpenSpace
+} from '@libs/auth'
 import {
   ConflictFoundException,
   EntityNotExistException,
@@ -94,8 +97,9 @@ export class SubmissionController {
   }
 
   @Get()
-  @AuthNotNeededIfOpenSpace()
+  @UserNullWhenAuthFailedIfOpenSpace()
   async getSubmissions(
+    @Req() req: AuthenticatedRequest,
     @Query('cursor', CursorValidationPipe) cursor: number | null,
     @Query('take', new DefaultValuePipe(10), new RequiredIntPipe('take'))
     take: number,
@@ -104,6 +108,7 @@ export class SubmissionController {
   ) {
     try {
       return await this.submissionService.getSubmissions({
+        userRole: req.user?.role,
         cursor,
         take,
         problemId,
@@ -173,6 +178,7 @@ export class ContestSubmissionController {
   ) {
     try {
       return await this.submissionService.getContestSubmissions({
+        userRole: req.user.role,
         cursor,
         take,
         problemId,

apps/backend/apps/client/src/submission/submission.service.ts

@@ -320,27 +320,31 @@ export class SubmissionService {
   // FIXME: Workbook 구분
   @Span()
   async getSubmissions({
+    userRole,
     problemId,
     groupId = OPEN_SPACE_ID,
     cursor = null,
     take = 10
   }: {
+    userRole?: Role
     problemId: number
     groupId?: number
     cursor?: number | null
     take?: number
   }) {
     const paginator = this.prisma.getPaginator(cursor)
 
-    await this.prisma.problem.findFirstOrThrow({
-      where: {
-        id: problemId,
-        groupId,
-        visibleLockTime: {
-          equals: MIN_DATE
+    if (!(userRole === 'Admin' || userRole === 'SuperAdmin')) {
+      await this.prisma.problem.findFirstOrThrow({
+        where: {
+          id: problemId,
+          groupId,
+          visibleLockTime: {
+            equals: MIN_DATE
+          }
         }
-      }
-    })
+      })
+    }
 
     const submissions = await this.prisma.submission.findMany({
       ...paginator,
@@ -515,13 +519,15 @@ export class SubmissionService {
 
   @Span()
   async getContestSubmissions({
+    userRole,
     problemId,
     contestId,
     userId,
     groupId = OPEN_SPACE_ID,
     cursor = null,
     take = 10
   }: {
+    userRole: Role
     problemId: number
     contestId: number
     userId: number
@@ -531,12 +537,7 @@ export class SubmissionService {
   }) {
     const paginator = this.prisma.getPaginator(cursor)
 
-    const isAdmin = await this.prisma.user.findFirst({
-      where: {
-        id: userId,
-        role: 'Admin'
-      }
-    })
+    const isAdmin = userRole === 'Admin' || userRole === 'SuperAdmin'
 
     if (!isAdmin) {
       await this.prisma.contestRecord.findUniqueOrThrow({

apps/backend/apps/client/src/submission/test/submission.service.spec.ts

@@ -530,6 +530,7 @@ describe('SubmissionService', () => {
 
       expect(
         await service.getContestSubmissions({
+          userRole: 'Admin',
           problemId: problems[0].id,
           contestId: 1,
           userId: submissions[0].userId
@@ -545,6 +546,7 @@ describe('SubmissionService', () => {
 
       await expect(
         service.getContestSubmissions({
+          userRole: 'User',
           problemId: problems[0].id,
           contestId: 1,
           userId: submissions[0].userId
@@ -560,6 +562,7 @@ describe('SubmissionService', () => {
 
       await expect(
         service.getContestSubmissions({
+          userRole: 'Admin',
           problemId: problems[0].id,
           contestId: 1,
           userId: submissions[0].userId

collection/client/Auth/Log In/Succeed.bru → collection/client/Auth/Log In/Succeed(Admin).bru

@@ -1,5 +1,5 @@
 meta {
-  name: Succeed
+  name: Succeed(Admin)
   type: http
   seq: 1
 }

collection/client/Auth/Log In/Succeed(User).bru

@@ -0,0 +1,27 @@
+meta {
+  name: Succeed(User)
+  type: http
+  seq: 5
+}
+
+post {
+  url: {{baseUrl}}/auth/login
+  body: json
+  auth: none
+}
+
+body:json {
+  {
+    "username": "user01",
+    "password": "Useruser"
+  }
+}
+
+vars:post-response {
+  jwtToken: res.headers.authorization
+}
+
+assert {
+  res.status: eq 201
+  res.headers.authorization: contains Bearer
+}