Skip to content

Commit

Permalink
change default xDS server to envoy
Browse files Browse the repository at this point in the history
Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
  • Loading branch information
skriss committed Feb 14, 2024
1 parent 6e6d2f7 commit 421c078
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion cmd/contour/servecontext_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ func TestConvertServeContext(t *testing.T) {
defaultContourConfiguration := func() contour_v1alpha1.ContourConfigurationSpec {
return contour_v1alpha1.ContourConfigurationSpec{
XDSServer: &contour_v1alpha1.XDSServerConfig{
Type: contour_v1alpha1.ContourServerType,
Type: contour_v1alpha1.EnvoyServerType,
Address: "127.0.0.1",
Port: 8001,
TLS: &contour_v1alpha1.TLS{
Expand Down
2 changes: 1 addition & 1 deletion examples/contour/01-contour-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data:
#
# server:
# determine which XDS Server implementation to utilize in Contour.
# xds-server-type: contour
# xds-server-type: envoy
#
# Specify the Gateway API configuration.
# gateway:
Expand Down
2 changes: 1 addition & 1 deletion examples/render/contour-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ data:
#
# server:
# determine which XDS Server implementation to utilize in Contour.
# xds-server-type: contour
# xds-server-type: envoy
#
# Specify the Gateway API configuration.
# gateway:
Expand Down
2 changes: 1 addition & 1 deletion examples/render/contour.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ data:
#
# server:
# determine which XDS Server implementation to utilize in Contour.
# xds-server-type: contour
# xds-server-type: envoy
#
# Specify the Gateway API configuration.
# gateway:
Expand Down
2 changes: 1 addition & 1 deletion internal/contourconfig/contourconfiguration.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func OverlayOnDefaults(spec contour_v1alpha1.ContourConfigurationSpec) (contour_
func Defaults() contour_v1alpha1.ContourConfigurationSpec {
return contour_v1alpha1.ContourConfigurationSpec{
XDSServer: &contour_v1alpha1.XDSServerConfig{
Type: contour_v1alpha1.ContourServerType,
Type: contour_v1alpha1.EnvoyServerType,
Address: "0.0.0.0",
Port: 8001,
TLS: &contour_v1alpha1.TLS{
Expand Down
4 changes: 2 additions & 2 deletions pkg/config/parameters.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (t ProtocolParameters) Validate() error {
// ServerParameters holds the configuration for the Contour xDS server.
type ServerParameters struct {
// Defines the XDSServer to use for `contour serve`.
// Defaults to "contour"
// Defaults to "envoy"
XDSServerType ServerType `yaml:"xds-server-type,omitempty"`
}

Expand Down Expand Up @@ -1036,7 +1036,7 @@ func Defaults() Parameters {
InCluster: false,
Kubeconfig: filepath.Join(os.Getenv("HOME"), ".kube", "config"),
Server: ServerParameters{
XDSServerType: ContourServerType,
XDSServerType: EnvoyServerType,
},
IngressStatusAddress: "",
AccessLogFormat: DEFAULT_ACCESS_LOG_TYPE,
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/parameters_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestParseDefaults(t *testing.T) {
debug: false
kubeconfig: TestParseDefaults/.kube/config
server:
xds-server-type: contour
xds-server-type: envoy
accesslog-format: envoy
json-fields:
- '@timestamp'
Expand Down
4 changes: 2 additions & 2 deletions site/content/docs/main/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ The server configuration block can be used to configure various settings for the

| Field Name | Type | Default | Description |
| --------------- | ------ | ------- | ----------------------------------------------------------------------------- |
| xds-server-type | string | contour | This field specifies the xDS Server to use. Options are `contour` or `envoy`. |
| xds-server-type | string | envoy | This field specifies the xDS Server to use. Options are `contour` or `envoy`. |

### Gateway Configuration

Expand Down Expand Up @@ -316,7 +316,7 @@ data:
#
# server:
# determine which XDS Server implementation to utilize in Contour.
# xds-server-type: contour
# xds-server-type: envoy
#
# specify the gateway-api Gateway Contour should configure
# gateway:
Expand Down

0 comments on commit 421c078

Please sign in to comment.