Code

ENH Polars support in Joiner#945

Code

Merged

jeromedockes merged 64 commits intoskrub-data:mainskrub-data/skrub:mainfrom TheooJ:refactor_joinerTheooJ/skrub:refactor_joinerCopy head branch name to clipboardJun 21, 2024

+481-327

Commits

Commits on Jun 12, 2024

• Plan out future changes, dispatch with_columns

  TheooJ

  committed
  849a701

Commits on Jun 13, 2024

• Dispatch left_join in _join_utils

  TheooJ

  committed
  66042e7

• Iter tests with_columns

  TheooJ

  committed
  6ed3203

• Iter left_join

  TheooJ

  committed
  72cad9b

• Use left_join in AggJoiner & AggTarget

  TheooJ

  committed
  aab6390

• .

  TheooJ

  committed
  d75e572

• Only drop right_on col when it is not equal to left_on

  TheooJ

  committed
  e047b7e

• Switch to default implem for with_columns

  TheooJ

  committed
  6c4c17b

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  b39f21a

• Format

  TheooJ

  committed
  595aab4

• Iter dispatch Joiner

  TheooJ

  committed
  2caa227

• Remove old test in pandas and polars

  TheooJ

  committed
  edac2d5

• Test with_columns

  TheooJ

  committed
  ec13d35

• More left_join tests

  TheooJ

  committed
  c3e290e

• Simplify test

  TheooJ

  committed
  d09359e

• Test make_column_like on col is col

  TheooJ

  committed
  2a04e99

• TODO

  TheooJ

  committed
  be7ec26

• Make Joiner work for Polars

  TheooJ

  committed
  686de71

Commits on Jun 16, 2024

• Apply suggestions from code review

  Show description for 8d6e624
  

  TheooJ

  and

  jeromedockes

  authored
  8d6e624

• Test & comment left_join

  TheooJ

  committed
  ccc67ba

Commits on Jun 17, 2024

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  1f0f2f6

• Apply suggestion from code review

  Show description for d5031d9
  

  TheooJ

  and

  jeromedockes

  authored
  d5031d9

• Address more review comments

  TheooJ

  committed
  d0796ec

• Check that make_column_like name is the requested name even if the input column has a different name

  TheooJ

  committed
  e21fb9a

Commits on Jun 18, 2024

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  b461c78

• CHANGES.rst

  TheooJ

  committed
  b9688c8

• Change iterable of str to list of str

  TheooJ

  committed
  41e385c

• Use df_module.assert_frame_equal

  TheooJ

  committed
  283ddb0

• Docstring

  TheooJ

  committed
  d59c916

• Iter test_joiner

  TheooJ

  committed
  6b7e379

• Add useful error msg for max_dist

  TheooJ

  committed
  e467994

• Add useful error msg for max_dist

  TheooJ

  committed
  4be4bdc

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  e84de29

• Merge branch 'refactor_joiner' of https://github.com/TheooJ/skrub into refactor_joiner

  TheooJ

  committed
  c250d26

• .

  TheooJ

  committed
  1ade2b0

• Handle case where main_key and aux_key are lists

  TheooJ

  committed
  14a3d97

• Test missing values, numeric, datetimes

  TheooJ

  committed
  5ab616a

• Test missing values, numeric, datetimes

  TheooJ

  committed
  92f78b0

Commits on Jun 19, 2024

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  72bea25

• Apply suggestions from code review

  Show description for 101d788
  

  TheooJ

  and

  jeromedockes

  authored
  101d788

• Merge branch 'refactor_joiner' of https://github.com/TheooJ/skrub into refactor_joiner

  TheooJ

  committed
  095d121

• Apply more suggestions from code review

  TheooJ

  committed
  8acbd92

• More suggestions from code review

  TheooJ

  committed
  4365d9c

• More suggestions from code review

  TheooJ

  committed
  aa7015d

• More suggestions from code review

  TheooJ

  committed
  da74a0c

• Add reset_index to _pandas.aggregate

  TheooJ

  committed
  c393088

• Dispatch fuzzy_join

  TheooJ

  committed
  a7f1ab7

• Format fuzzy_join

  TheooJ

  committed
  af684c3

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  6e4420c

• Dispatch filter in fuzzy_join

  TheooJ

  committed
  5f2fd60

• Fix pandas aggregate testing

  TheooJ

  committed
  5accc20

• fix joiner for old sklearn

  jeromedockes

  committed
  1f4d49d

Commits on Jun 20, 2024

• specify right key dtype

  jeromedockes

  committed
  86efa01

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  54d49f9

• Merge pull request #2 from jeromedockes/fix-old-column-transformer

  Show description for 5ebbe9a
  TheooJ

  authored
  5ebbe9a

• Dispatch fuzzy_join tests

  TheooJ

  committed
  206fe54

• Next steps

  TheooJ

  committed
  3e4a597

• Format tests

  TheooJ

  committed
  d139fd8

Commits on Jun 21, 2024

• Apply suggestions from code review

  Show description for 3f4d4bb
  

  TheooJ

  and

  jeromedockes

  authored
  3f4d4bb

• More suggestions from code review

  TheooJ

  committed
  79f1192

• Dispatch test_join_utils

  TheooJ

  committed
  36d81ff

• Merge branch 'main' into refactor_joiner

  TheooJ

  committed
  9517280

• More suggestions from code review

  TheooJ

  committed
  f2717c2

• Test duplicated key and col names

  TheooJ

  committed
  557a326