Improve framework detection logic and add test coverage #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_the_default_framework
skryukov
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Looks great, thanks @brodienguyen! Could you port this to inertia-rails instead? I'm about to drop the installation support from this gem in upcoming week 😅
| @@ -15,3 +15,6 @@ docs/.vitepress/dist | |||
| docs/.vitepress/cache | |||
|
|
|||
| Gemfile.lock | |||
|
|
|||
| # JetBrains | |||
| .idea | |||
There was a problem hiding this comment.
imo, IDE-specific ignores work better in the global git config. In other cases OSS projects get invaded by different IDE users 😅
There was a problem hiding this comment.
Haha, I keep changing work machine so I am a bit lazy to configure those global settings. Properly it's time to unwind that bad habit then.
There was a problem hiding this comment.
@skryukov I ported back to inertia-rails at:
I am going to close this PR to avoid double handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR perform some changes:
InertiaRailsContrib::GeneratorsHelper#guess_the_default_frameworkmethod.