Fix mention plugin crashes

skychatorg · Aug 10, 2024 · 66343a3 · 66343a3
1 parent 91f2339
commit 66343a3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/app/server/plugins/core/room/MentionPlugin.ts b/app/server/plugins/core/room/MentionPlugin.ts
@@ -13,7 +13,12 @@ export class MentionPlugin extends RoomPlugin {
     async run(): Promise<void> {}
 
     // Intercept quotes in messages
-    public async onBeforeMessageBroadcastHook(message: Message, connection: Connection) {
+    public async onBeforeMessageBroadcastHook(message: Message, connection?: Connection) {
+        // It is currently not possible to mention an user if there's not connection the mention originates from
+        if (!connection) {
+            return message;
+        }
+
         if (connection.session.user.right < Config.PREFERENCES.minRightForUserMention) {
             return message;
         }