Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tx icons #434

Closed
wants to merge 1 commit into from
Closed

Change tx icons #434

wants to merge 1 commit into from

Conversation

Senyoret1
Copy link
Collaborator

Fixes #422

Changes:

  • The history page now shows a green icon for incoming transactions and a red one for outgoing transactions. Additionally, the icon is the same one used in the header, to maintain consistency. The change does not have esthetic ends, the objetive is to help to be able to quickly navigate through the history of transactions, because the icons that have been used until now are difficult to differentiate in a quick glance:
    old
    new

  • TransactionInfoComponent uses the new colored icons, but only if opened in the history page. When sending a transaction the icon is blue, to avoid generating a negative feeling with the red color. However, the blue icon was replaced by the one in the header, to maintain consistency.

@Senyoret1 Senyoret1 requested a review from mahansky July 18, 2018 18:49
Copy link
Contributor

@mahansky mahansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'm not a huge fan of the colors though. I would probably try grey (sent) and blue (received) and leave TransactionInfoComponent without change. It's up to you..

@Senyoret1
Copy link
Collaborator Author

I tried some other designs and I liked almost nothing, but maybe this could work:
icons
The vertical line allows to know if the arrow is entering or leaving, and the two designs seem to be different enough to differentiate them in a quick view of the list (mainly due to the overall shape). it's a very simple change, but at least it's consistent with the rest of the design. What do you think, @mahansky?

@mahansky
Copy link
Contributor

I don't know, I'm not too happy with that either. I mean, the logic behind it is good; Maybe a dot instead of a line with a bit of space? . < and . >.

@Senyoret1
Copy link
Collaborator Author

I changed the lines with dots, as you suggested. Viewing the result I think it is not so easy to differentiate the two icons, as with the lines, which is a problem. Here is an example:
dot

I also modified the line icons, using smaller arrows. I think it looks a little better than with the big arrows:
small

Actually I did some tests with more elaborate designs, but the design of the wallet has very simple elements. It is difficult to use an icon with a complex design and make it look consistent, so I think the options are few. Here is an example of a complex design I tried:
shadow

@mahansky
Copy link
Contributor

The last one is pretty sweet but as you said, it doesn't really fit into the current design.
What if you combined the lines and that last design in such a way that the line would be on the very left of the transaction row (similar to border but on the inside and not full height) and the arrow the way it was or maybe smaller, bit closer to the left?
Kind of hard to describe it but I dont have any img editor on this computer.

@gz-c
Copy link
Member

gz-c commented Jul 15, 2019

@Senyoret1 this is very old, are we continuing with it?

@Senyoret1
Copy link
Collaborator Author

@gz-c I stoppend working on this long ago, so I will close it. If needed, I will check it again later

@Senyoret1 Senyoret1 closed this Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the "sent" and "received" icons
3 participants