-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tx icons #434
Change tx icons #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I'm not a huge fan of the colors though. I would probably try grey (sent) and blue (received) and leave TransactionInfoComponent without change. It's up to you..
I tried some other designs and I liked almost nothing, but maybe this could work: |
I don't know, I'm not too happy with that either. I mean, the logic behind it is good; Maybe a dot instead of a line with a bit of space? |
The last one is pretty sweet but as you said, it doesn't really fit into the current design. |
@Senyoret1 this is very old, are we continuing with it? |
@gz-c I stoppend working on this long ago, so I will close it. If needed, I will check it again later |
Fixes #422
Changes:
The history page now shows a green icon for incoming transactions and a red one for outgoing transactions. Additionally, the icon is the same one used in the header, to maintain consistency. The change does not have esthetic ends, the objetive is to help to be able to quickly navigate through the history of transactions, because the icons that have been used until now are difficult to differentiate in a quick glance:
TransactionInfoComponent
uses the new colored icons, but only if opened in the history page. When sending a transaction the icon is blue, to avoid generating a negative feeling with the red color. However, the blue icon was replaced by the one in the header, to maintain consistency.