Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keys-gen app #49

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Feb 3, 2024

Fixes: #7

Changes:

  • remove key-gens cmd app

Description:
address-gen on Skycoin needs a little fix (missing label value), also I add new flag -key-pairs to printout only key pairs there. So if we can merge related PR on Skycoin (skycoin/skycoin#2713) we can merge this PR too. Otherwise, we should close both of them and keep key-gens here.

@0pcom
Copy link
Collaborator

0pcom commented Feb 27, 2024

I will note that the functionality of keys-gen is duplicated for skywire-cli config gen-keys

However, I'm uncertain that we should remove it. What is the suggested alternative method for doing this? I would just hate to make an inconvenient situation for future developers where they needed to look in a different repo for this utility.

Note also that some documentation may reflect the use of keys-gen. So that documentation may need be changed (check skywire-deployment repo) if this utility is removed.

I might suggest simply relocating it from cmd/ to some subdirectory of examples/ - just in case / for convenience.

Unless there is another easy way to do this that i'm missing.

@0pcom
Copy link
Collaborator

0pcom commented Feb 27, 2024

on second thought, i suggest move keys-gen to skywire-utilities. I think that is an appropriate place for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants