fix: emitter off

skyllo · Jul 21, 2022 · b2d3947 · b2d3947
1 parent d1616a9
commit b2d3947
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/emitter.ts b/src/emitter.ts
@@ -20,7 +20,7 @@ export class EventEmitter {
 
   public off(event: string, listener: ListenerFunction) {
     const listeners = this.eventMap[event] ?? [];
-    for (let i = listeners.length; i > 0; i -= 1) {
+    for (let i = listeners.length - 1; i >= 0; i -= 1) {
       if (listeners[i] === listener) {
         listeners.splice(i, 1);
         break;

diff --git a/test/emitter.spec.ts b/test/emitter.spec.ts
@@ -39,3 +39,14 @@ test('emitter can remove multiple listeners', () => {
   emitter.emit('eventName');
   expect(spyFunc).toBeCalledTimes(0);
 });
+
+test('emitter can remove single listener', () => {
+  const spyFunc = jest.fn();
+  const emitter = new EventEmitter();
+  emitter.on('eventName', spyFunc);
+  emitter.off('eventName', spyFunc);
+  emitter.emit('eventName');
+  expect(spyFunc).toBeCalledTimes(0);
+
+  spyFunc.mockClear();
+});