Skip to content

Commit

Permalink
[k8s] Fix generate_kubeconfig.sh when ingress is not used (#3864)
Browse files Browse the repository at this point in the history
* fix kubeconfig generate script

* updates
  • Loading branch information
romilbhardwaj committed Sep 6, 2024
1 parent 2e545b8 commit 3159281
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion sky/utils/kubernetes/generate_kubeconfig.sh
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ roleRef:
kind: Role
name: skypilot-system-service-account-role
apiGroup: rbac.authorization.k8s.io
---
EOF
# Apply optional ingress-related roles, but don't make the script fail if it fails
kubectl apply -f - <<EOF || echo "Failed to apply optional ingress-related roles. Nginx ingress is likely not installed. This is not critical and the script will continue."
# Optional: Role for accessing ingress resources
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
Expand Down

0 comments on commit 3159281

Please sign in to comment.