-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] Allow resource group specifiation for Azure instance provisioning #3764
Open
landscapepainter
wants to merge
35
commits into
skypilot-org:master
Choose a base branch
from
landscapepainter:azure-instance-resource-group-specification
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Azure] Allow resource group specifiation for Azure instance provisioning #3764
landscapepainter
wants to merge
35
commits into
skypilot-org:master
from
landscapepainter:azure-instance-resource-group-specification
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
@landscapepainter if we plan to get this in for 0.7, can we resolve merge conflicts so we can start reviewing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #3659
Tested (run the relevant ones):
bash format.sh
storage_account
along withresource_group_vm
both specified at~/.sky/config.yaml
config.yaml
and remove Asky serve up
is created at the specified resource group.pytest tests/test_smoke.py
pytest tests/test_smoke.py --azure
except:tests/test_smoke.py::test_cancel_pytorch
pytest tests/test_smoke.py::test_fill_in_the_name
resource_group_vm
specified