feat: add SweetPieSpellDamageFormula for spell damage modification #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellipsis-dev
bot
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 262de48 in 1 minute and 40 seconds
More details
- Looked at
187lines of code in4files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skymp5-server/cpp/server_guest_lib/formulas/SweetPieSpellDamageFormula.h:48
- Draft comment:
Addoverridekeyword toCalculateDamagefunction declaration for clarity and correctness. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. skymp5-server/cpp/server_guest_lib/formulas/SweetPieSpellDamageFormula.cpp:31
- Draft comment:
Initialization ofsettingstostd::nulloptis redundant and can be omitted. - Reason this comment was not posted:
Confidence changes required:50%
TheSweetPieSpellDamageFormulaconstructor initializessettingstostd::nullopt, but it is not clear if this is necessary sincesettingsis already anstd::optional. This initialization can be omitted for cleaner code.
Workflow ID: wflow_tIfhOZZuhUAf5b9u
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const float baseDamage = | ||
| baseFormula->CalculateDamage(aggressor, target, spellCastData); | ||
|
|
||
| if (!setings) { |
There was a problem hiding this comment.
Typo in variable name: 'setings' should be 'settings'.
|
|
||
| namespace SweetPieSpellDamageFormulaPrivate { | ||
| template <class T> | ||
| T Clamp(T value, T minValue, T maxValue) |
There was a problem hiding this comment.
This implements the same value clamping logic as the existing CropValue function. Consider either using that function (if float is sufficient) or making it generic.
- function
CropValue(CropRegeneration.cpp)
nic11
reviewed
Dec 6, 2024
| #include <limits> | ||
| #include <sstream> | ||
|
|
||
| namespace SweetPieSpellDamageFormulaPrivate { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
SweetPieSpellDamageFormulato modify spell damage based on item multipliers, configurable via JSON, and integrate it into the server's damage calculation.SweetPieSpellDamageFormulato modify spell damage based on item multipliers inScampServer.cpp.sweetPieSpellDamageFormulaSettingsin JSON.SweetPieSpellDamageFormulainSweetPieSpellDamageFormula.cppandSweetPieSpellDamageFormula.h.CalculateDamage()forSpellCastDataandHitData.SweetPieSpellDamageFormulaSettings::FromJson().SweetPieDamageFormula.hto specify it modifies weapon damage.This description was created by
for 262de48. It will automatically update as commits are pushed.