Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: rearrange Git SHA capture in workflow #2279

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Dec 22, 2024

Important

Rearrange steps in action.yml to capture Git SHA before gathering PRs, removing duplicate step.

  • Workflow Changes:
    • Move "Get Git SHA" step before "Gather PRs" step in action.yml to capture SHA before changes.
    • Remove duplicate "Get Current Git SHA" step after "Gather PRs".

This description was created by Ellipsis for c730cfc. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title . fix: rearrange Git SHA capture in workflow Dec 22, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c730cfc in 11 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/actions/pr_base/action.yml:59
  • Draft comment:
    The 'Get Git SHA Before Gather' step is correctly moved before the 'Commit gathered PRs' step to capture the SHA before any new commits. Ensure that this change aligns with the intended workflow.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The change involves moving the 'Get Current Git SHA' step before the 'Commit gathered PRs' step. This is logical because the SHA should be captured before any new commits are made.

Workflow ID: wflow_l3cru5wPLKN4CluX


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove changed the title fix: rearrange Git SHA capture in workflow internal: rearrange Git SHA capture in workflow Dec 22, 2024
@Pospelove Pospelove merged commit c4a928d into skyrim-multiplayer:main Dec 22, 2024
12 checks passed
@Pospelove Pospelove deleted the cache2 branch December 22, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant