Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skymp5-front): add a description of spell reset #2283

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

IceLeon911
Copy link
Collaborator

@IceLeon911 IceLeon911 commented Dec 26, 2024

Important

Update confirmHanlder in index.tsx to include losing learned spells in reset confirmation description.

  • Behavior:
    • Update confirmHanlder in index.tsx to include losing learned spells in the reset confirmation description.

This description was created by Ellipsis for 05107a6. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 05107a6 in 7 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skymp5-front/src/features/skillsMenu/index.tsx:181
  • Draft comment:
    The change correctly updates the description to include information about losing spells when resetting progress. This aligns with the PR's intent.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a description about losing spells when resetting progress. This change is straightforward and aligns with the intent of the PR.

Workflow ID: wflow_DB3zQwzHZyU7zzYv


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove changed the title Add a description of spell reset feat(skymp5-front): add a description of spell reset Dec 26, 2024
@Pospelove Pospelove merged commit c26471d into main Dec 26, 2024
19 checks passed
@Pospelove Pospelove deleted the IceLeon911-patch-1 branch December 26, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants