Fix render glitches and support Spritekit, SceneKit and GLKit #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twice with drawHierarchy+layer.render
|
This is AWESOME mate!!!, sorry for the delay in the review, thank you very much for this, I'll prepare a release with this great feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #30
This also changes UIView+Render to only render the layer. The current code actually renders the image twice, once via drawHierarchy and once via layer.render - if there is transparency involved, having these two images drawn on top of each other causes render glitches.
layer.render seems to always work while drawHierarchy only works when a UIWindow/host application is present.
Unfortunately, this might change the rendered image - no visible changes, but the values will differ +- 2 or 3. There seems to be some subtle difference in rendering depending on the API you use. So users who have generated test images before might have to regenerate them :(