Skip to content

Commit

Permalink
Remove mysql57/percona57 bootstrap images (vitessio#16620)
Browse files Browse the repository at this point in the history
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
  • Loading branch information
frouioui authored and venkatraju committed Aug 29, 2024
1 parent 05ecef3 commit a143ba3
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 50 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ $(PROTO_GO_OUTS): minimaltools install_protoc-gen-go proto/*.proto
# Please read docker/README.md to understand the different available images.

# This rule builds the bootstrap images for all flavors.
DOCKER_IMAGES_FOR_TEST = mysql57 mysql80 percona57 percona80
DOCKER_IMAGES_FOR_TEST = mysql80 percona80
DOCKER_IMAGES = common $(DOCKER_IMAGES_FOR_TEST)
BOOTSTRAP_VERSION=35
ensure_bootstrap_version:
Expand Down
3 changes: 2 additions & 1 deletion docker/bootstrap/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,4 +136,5 @@ List of changes between bootstrap image versions.

## [35] - 2024-08-14
### Changes
- Update build to golang 1.23.0
- Update build to golang 1.23.0
- MySQL57 and Percona57 tags will be removed thereafter
24 changes: 0 additions & 24 deletions docker/bootstrap/Dockerfile.mysql57

This file was deleted.

21 changes: 0 additions & 21 deletions docker/bootstrap/Dockerfile.percona57

This file was deleted.

2 changes: 0 additions & 2 deletions docker/bootstrap/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ after successfully running `bootstrap.sh` and `dev.env`.
The `vitess/bootstrap` image comes in different flavors:

* `vitess/bootstrap:common` - dependencies that are common to all flavors
* `vitess/bootstrap:mysql57` - bootstrap image for MySQL 5.7
* `vitess/bootstrap:mysql80` - bootstrap image for MySQL 8.0
* `vitess/bootstrap:percona57` - bootstrap image for Percona Server 5.7
* `vitess/bootstrap:percona80` - bootstrap image for Percona Server 8.0

**NOTE: Unlike the base image that builds Vitess itself, this bootstrap image
Expand Down
2 changes: 1 addition & 1 deletion test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const (
configFileName = "test/config.json"

// List of flavors for which a bootstrap Docker image is available.
flavors = "mysql57,mysql80,percona,percona57,percona80"
flavors = "mysql80,percona80"
)

// Config is the overall object serialized in test/config.json.
Expand Down

0 comments on commit a143ba3

Please sign in to comment.