Use node.Name only if set

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
slackhq · Jun 19, 2024 · cb6e9ad · cb6e9ad
1 parent 20ee454
commit cb6e9ad
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/go/vt/sqlparser/ast_format.go b/go/vt/sqlparser/ast_format.go
@@ -2656,7 +2656,12 @@ func (node *Count) Format(buf *TrackedBuffer) {
 }
 
 func (node *CountStar) Format(buf *TrackedBuffer) {
- buf.astPrintf(node, "%s(*)", node.Name)
+ if node.Name != "" {
+ buf.astPrintf(node, "%s(*)", node.Name)
+ } else {
+ buf.astPrintf(node, "%s(", node.AggrName())
+ buf.WriteString("*)")
+ }
 }
 
 func (node *Avg) Format(buf *TrackedBuffer) {

diff --git a/go/vt/sqlparser/ast_format_fast.go b/go/vt/sqlparser/ast_format_fast.go