Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-15.0: refactor private go dep config from #367 #375

Merged
merged 1 commit into from
May 28, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented May 28, 2024

Description

This PR refactors #367 by moving the git config commands to setup private-repo access (for our custom durability policy) into build.env, so the logic is more general and the GitHub token is not leaked in CI output

A separate, internal PR will occur to add GOPRIVATE to our CI environment

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v15.0.5 milestone May 28, 2024
@timvaillancourt timvaillancourt marked this pull request as ready for review May 28, 2024 15:12
@timvaillancourt timvaillancourt requested a review from a team as a code owner May 28, 2024 15:12
@timvaillancourt timvaillancourt merged commit 20379c2 into slack-15.0 May 28, 2024
195 checks passed
@timvaillancourt timvaillancourt deleted the private-repo-build.env-slack-15.0 branch May 28, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants