New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`slack-19.0`: init v19 release and backport v20 PRs #386

Merged

timvaillancourt merged 29 commits into slack-19.0 from bp-v20-prs-slack-19.0

Jul 9, 2024

Member

timvaillancourt commented May 30, 2024 •

edited

Loading

Description

This PR contains the typical hacks for a Slack release such as:

CI runner updates to slackhq self-hosted
Delete skip logic in tests (always run full CI)
Private repo git-config for https://github.com/slackhq/vitess-addons
CODEOWNERS setup for @slackhq/vitess-approvers
Previous/downgrade-CI release set to https://github.com/slackhq/vitess/tree/slack-15.0
A fix applied for issues downloading percona-xtrabackup-24 from Percona

Also all v20 backports we require we cherry picked, also 1 x to-be-upstreamed patch was forward-ported

v19 sideports

v20 Backports

Load --grpc_auth_static_client_creds file once vitessio/vitess#15030
- Stopped vtgate crashing in v14 upgrade
Limit concurrent creation of healthcheck gRPC connections vitessio/vitess#15053
- Stopped vtgate crashing in v14 upgrade
Filter by keyspace earlier in tabletgateways WaitForTablets(...) vitessio/vitess#15347
Make Durabler interface methods public vitessio/vitess#15548
- Required by our custom Durability Policy

Internal Patches

slack-vitess-r14.0.5: allow conn overrides in consul topo #111

Checklist

"Backport to:" labels have been added if this change should be back-ported
Tests were added or are not required
Did the new or modified tests pass consistently locally and on the CI
Documentation was added or is not required

Deployment Notes

timvaillancourt and others added 5 commits

May 30, 2024 23:50


          Make Durabler interface methods public (vitessio#15548)

83a2c17

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>


          Load --grpc_auth_static_client_creds file once (vitessio#15030)

66da8f3

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Limit concurrent creation of healthcheck gRPC connections (vitessio#1…

ebe1c61

…5053)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Filter by keyspace earlier in tabletgateways WaitForTablets(...) (v…

6f12a6e

…itessio#15347)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Use slack-15.0 as previous release

7132da2

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

timvaillancourt added v19 upstream-backport v20-backport labels

github-actions bot added this to the v19.0.4 milestone

timvaillancourt added 8 commits

May 31, 2024 01:57


          empty commit

1fdd1a5

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          force ci to run

efea4a0


          Update GH Action runners

563b839

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          test templates

e2a7d5e

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          set GH access token in build

a15511f

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Fix reparent old tests

c719465

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Remove CIs we don't need

0b0ae08

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Remove CIs we don't need again

482f4c9

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

slackhq deleted a comment from codecov-commenter

timvaillancourt added 2 commits

June 1, 2024 00:13


          Add private repo setup to upgrade_downgrade_test_backups_e2e.yml

bb146da

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Add private repo setup to more CI

d696c9a

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

slackhq deleted a comment from codecov-commenter

timvaillancourt added 2 commits

June 1, 2024 00:42


          remove CI skip logic for upstream stuff

b8b8b61

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          CODEOWNERS

ba4be6c

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

github-actions bot added the Stale label

timvaillancourt removed the Stale label


          [release-19.0] Add timeout to all the contexts used for RPC calls in …

462f380

…vtorc (vitessio#15991) (vitessio#16103)

Signed-off-by: Manan Gupta <manan@planetscale.com>

salesforce-cla bot added the cla:missing label

salesforce-cla bot commented Jul 9, 2024

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 to sign the Salesforce Inc. Contributor License Agreement.


          slack-vitess-r15.0.5: forward-port consul topo limits PR #111 (#297)

2dfc4d3

* `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111)

* `slack-vitess-r14.0.5`: allow conn overrides in consul topo

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* fix e2e test

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Update flags tests that didn't exist in v14

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

---------

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

slackhq deleted a comment from codecov-commenter

timvaillancourt added the slack-cherrypick label

timvaillancourt added 2 commits

July 9, 2024 17:33


          update vtcombo e2e

69949a2

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Fix err with installing percona-xtrabackup-24

d991fe9

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

slackhq deleted a comment from github-actions bot

timvaillancourt added 5 commits

July 9, 2024 19:04


          slack-vitess-r15.0.5: fix races in Unit Test (Race) CI, fix "old"…

93ac79f

… reparent CIs (#356)


          update vtcombo e2e test

cd196c8

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          Fix bad merge conflict fix

824663c

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          go mod tidy

574bb20

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          update vtcombo e2e test again

c23b329

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

timvaillancourt changed the title ~~slack-19.0: backport v20 PRs, set slack-15.0 as previous release~~ slack-19.0: init v19 release and backport v20 PRs


          [release-19.0] Upgrade the Golang version to go1.22.5 (vitessio#16322)

99a019f

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

salesforce-cla bot commented Jul 9, 2024

Thanks for the contribution! Before we can merge this, we need @GuptaManan100 @vitess-bot to sign the Salesforce Inc. Contributor License Agreement.

timvaillancourt added 2 commits

July 9, 2024 21:22


          merge conflict fixes

f90a960

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>


          make vtadmin_web_proto_types

06f0844

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

timvaillancourt marked this pull request as ready for review

July 9, 2024 20:07

Member Author

timvaillancourt commented Jul 9, 2024

Merging with these 6 x known downgrade failures (with slack-15.0) that will be resolved in follow-up PRs

Screenshot 2024-07-09 at 23 00 02

timvaillancourt merged commit 15ee54c into slack-19.0

192 of 199 checks passed

timvaillancourt deleted the bp-v20-prs-slack-19.0 branch

July 9, 2024 21:01

timvaillancourt modified the milestones: v19.0.4, v19.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:missing slack-cherrypick upstream-backport v19 v20-backport