Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport upstream: do not demote a new primary after backup completion (#12856) #423

Closed
wants to merge 3 commits into from

Commits on Jun 24, 2024

  1. do not demote a new primary after backup completion (vitessio#12856)

    * do not demote a new primary after backup completion
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * move set replication source out of vtctld and into tablet
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * remove set replication source in vtctld
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * fix ctx, and wip test
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * add e2e test instead of unit test
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * use built in methods
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * omit this in test
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * Update go/vt/vttablet/tabletmanager/rpc_backup.go
    
    Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    Signed-off-by: Olga Shestopalova <olgash@mit.edu>
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * move wg done to top of func
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * fix method change
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    Signed-off-by: <oshestopalova@hubspot.com>
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * try running this in isolation
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * try running this in isolation, dont run with others
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * add debug logging
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * add debug logging
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * Update go/test/endtoend/backup/vtctlbackup/backup_utils.go
    
    Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
    Signed-off-by: Olga Shestopalova <olgash@mit.edu>
    
    * Update go/test/endtoend/backup/vtctlbackup/backup_utils.go
    
    Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
    Signed-off-by: Olga Shestopalova <olgash@mit.edu>
    
    * run goimports
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * remove dupe
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    * remove generated file
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    
    ---------
    
    Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
    Signed-off-by: Olga Shestopalova <olgash@mit.edu>
    Signed-off-by: <oshestopalova@hubspot.com>
    Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com>
    Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
    4 people authored and tanjinx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    442af43 View commit details
    Browse the repository at this point in the history
  2. fix test

    tanjinx committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3ac6b17 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. remove duplicate code

    tanjinx committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4cd293b View commit details
    Browse the repository at this point in the history