slack-19.0
: disable --config-file-not-found-handling
on v15 tests, remove mysql57
CI
#446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents the flag
--config-file-not-found-handling
to be set on upgrade/downgrade tests where binaries are not v19, using this tweak below. Also CI tests formysql57
were deletedvitess/examples/common/env.sh
Lines 35 to 38 in 1f8c487
This prevents the error
unknown flag: --config-file-not-found-handling
on someslack-15.0
-downgrade CIFailures in the following CI are expected and will be fixed in a subsequent PR:
Query Serving (Queries) - Upgrade Downgrade Testing
Query Serving (Schema) - Upgrade Downgrade Testing
Both of these CIs are currently not-required for merge
Related Issue(s)
Checklist
Deployment Notes