Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-19.0: disable --config-file-not-found-handling on v15 tests, remove mysql57 CI #446

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

timvaillancourt
Copy link
Member

@timvaillancourt timvaillancourt commented Jul 9, 2024

Description

This PR prevents the flag --config-file-not-found-handling to be set on upgrade/downgrade tests where binaries are not v19, using this tweak below. Also CI tests for mysql57 were deleted

BINARY_VERSION=$($binary --version | grep -o "Version: 1[0-9]\.[0-9]*\.[0-9]*" | awk '{print $2}')
if [[ "${BINARY_VERSION}" =~ 19.0.[0-9]* ]]; then
alias $binary="$binary --config-file-not-found-handling=ignore"
fi

This prevents the error unknown flag: --config-file-not-found-handling on some slack-15.0-downgrade CI

Failures in the following CI are expected and will be fixed in a subsequent PR:

  • Query Serving (Queries) - Upgrade Downgrade Testing
  • Query Serving (Schema) - Upgrade Downgrade Testing

Both of these CIs are currently not-required for merge

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@github-actions github-actions bot added this to the v19.0.4 milestone Jul 9, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt changed the title slack-19.0: disable --config-file-not-found-handling on v15 tests slack-19.0: disable --config-file-not-found-handling on v15 tests, remove mysql57 CI Jul 9, 2024
@timvaillancourt timvaillancourt marked this pull request as ready for review July 9, 2024 22:28
@timvaillancourt timvaillancourt requested a review from a team as a code owner July 9, 2024 22:28
@timvaillancourt timvaillancourt merged commit 2b80e09 into slack-19.0 Jul 9, 2024
159 of 163 checks passed
@timvaillancourt timvaillancourt deleted the fix-backup-downgrade-ci-slack-19.0 branch July 9, 2024 22:45
@timvaillancourt timvaillancourt modified the milestones: v19.0.4, v19.0.5 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants