Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack-19.0: fix docker base build + git private repo #456

Merged
merged 1 commit into from
Jul 17, 2024
Merged

slack-19.0: fix docker base build + git private repo #456

merged 1 commit into from
Jul 17, 2024

Conversation

timvaillancourt
Copy link
Member

Description

This PR copies a fix from v15 for docker build-time problems cloning our private addons repo

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt
slack-19.0: fix docker base build + git private repo
bfac304 
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt requested a review from a team as a code owner July 17, 2024 20:15
@github-actions github-actions bot added this to the v19.0.4 milestone Jul 17, 2024
@timvaillancourt timvaillancourt merged commit 1298a0f into slack-19.0 Jul 17, 2024
155 of 164 checks passed
@timvaillancourt timvaillancourt deleted the slack_cross_cell_pt2-slack-19.0 branch July 17, 2024 20:27
@timvaillancourt
Copy link
Member Author

Force merged because CI can't test this change

@timvaillancourt timvaillancourt modified the milestones: v19.0.4, v19.0.5 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbibra pbibra pbibra approved these changes

Assignees
No one assigned
Labels
custom-patch v19
Projects
None yet
Milestone
v19.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@timvaillancourt @pbibra