Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting grpc send and recv message sizes independently #481

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

henryr
Copy link

@henryr henryr commented Aug 9, 2024

We would like to set the send and recv max message sizes independently on vtgates. This allows us to keep a small limit on the size of the messages received from tablets, while allowing vtgates to send a large aggregated response to clients.

Two new flags are added: grpc_max_message_send_size and grpc_max_message_recv_size. These are 0 by default, in which case the existing grpc_max_message_size flag is used with no change from the existing behaviour. If set to non-0, they override the setting for grpc_max_message_size.

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
@henryr henryr requested a review from a team as a code owner August 9, 2024 14:07
@github-actions github-actions bot added this to the v15.0.5 milestone Aug 9, 2024
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
rjlaine
rjlaine previously approved these changes Aug 9, 2024
Copy link
Collaborator

@rjlaine rjlaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbibra
Copy link

pbibra commented Aug 9, 2024

this lgtm! I think we'll want to update all the txt help files with the two new flags to get some of the unit tests passing. Since they all use these grpc common options

topo2topo.txt
vtbackup.txt
vtbench.txt
vtclient.txt
vtcombo.txt
vtctlclient.txt
vtctld.txt
vtctldclient.txt
vtgate.txt
vtgateclienttest.txt
vtorc.txt
vttablet.txt
vttestserver.txt

@henryr
Copy link
Author

henryr commented Aug 12, 2024

@pbibra where are those files? I don't see them in my slack-15 checkout (alternatively, which tests should I run locally to trigger those failures?)

Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
@henryr
Copy link
Author

henryr commented Aug 12, 2024

@pbibra I found some of them, let me know if others (like topo2topo.txt) still need updating.

rjlaine
rjlaine previously approved these changes Aug 12, 2024
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
@pbibra
Copy link

pbibra commented Aug 12, 2024

@pbibra I found some of them, let me know if others (like topo2topo.txt) still need updating.

No sorry! That list was from the v19 branch - you got all of them here! The tests are in flags_test.go and can be run locally after running make build.

/usr/bin/go test -timeout 30s -run ^TestHelpOutput$ vitess.io/vitess/go/flags/endtoend

@pbibra pbibra merged commit 0f06ea0 into slack-15.0 Aug 12, 2024
194 checks passed
@pbibra pbibra deleted the hnr-separate-grpc-size-flags branch August 12, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants