Backport select backup engine in Backup() and ignore engines in RestoreFromBackup() #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kup() (vitessio#16428) Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
rvrangel
commented
Oct 29, 2024
Comment on lines
1356
to
1359
| // localCluster.DisableVTOrcRecoveries(t) | ||
| // defer func() { | ||
| // localCluster.EnableVTOrcRecoveries(t) | ||
| // }() |
There was a problem hiding this comment.
these do not exist in v15 yet, but leaving it here for context of the reviewer
rvrangel
commented
Oct 29, 2024
Comment on lines
1401
to
1404
| // localCluster.DisableVTOrcRecoveries(t) | ||
| // defer func() { | ||
| // localCluster.EnableVTOrcRecoveries(t) | ||
| // }() |
timvaillancourt
previously approved these changes
Oct 29, 2024
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
timvaillancourt
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backports vitessio#16428
Related Issue(s)
Checklist
Deployment Notes