Move datetime-specific code from date methods into datetime class #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@5j9 please rebase on top of main |
_strftime_p: only raises Exception (AttributeError) on date objects because dates do not have hour attribute. _strftime_z: only raises AttributeError on a date class becuase date does not have utcoffset attribute. _strftime_cap_z: date does not have tzname attribute, but datetime has.
hramezani
approved these changes
Apr 7, 2024
|
Thanks @5j9 |
|
Nice work @5j9 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the logic and improves readability by moving datetime-specific code branches to datetime class.
Also resolves some code linter warnings about attributes not being defined on date class.
_strftime_p: only raises Exception (AttributeError) on date objects because dates do not have hour attribute.
_strftime_z: only raises AttributeError on a date class becuase date does not have utcoffset attribute.
_strftime_cap_z: date does not have tzname attribute, but datetime has.