Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes and response example according to API changes #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update release notes and response example according to API changes #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions app/views/services/autoform/integration_manual.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,31 @@
"registration_number": "VVS/1-900/90-48099",
"updated_at": "2019-12-10T08:47:03.195891Z",
"legal_form": "Združenie (zväz, spolok, spoločnosť, klub ai.)",
"main_economic_activity": null,
"statutory_bodies": [
{
"type": "Iný štatutárny orgán",
"first_name": "Ľubor",
"last_name": "Illek",
"street": "Líščie údolie",
"reg_number": 3710,
"building_number": "33",
"postal_code": null,
"municipality": "Bratislava - mestská časť Karlova Ves",
"country": "Slovenská republika"
},
{
"type": "Iný štatutárny orgán",
"first_name": "Gabriel",
"last_name": "Lachmann",
"street": "Belániková",
"reg_number": 3574,
"building_number": "6",
"postal_code": null,
"municipality": "Bratislava - mestská časť Karlova Ves",
"country": "Slovenská republika"
}
],
"statutory": [
{
"type": "Iný štatutárny orgán",
Expand Down
14 changes: 14 additions & 0 deletions app/views/static/release_notes.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
<div class="container">
<h1><strong>Poznámky k zmenám funkcionality a štruktúry dát</strong></h1>
<div class="long-text">
<h2 class="anchorable">Zmena k 3. 12. 2020</h2>
<h3>Autoform API</h3>
Copy link
Contributor

@pavolzbell pavolzbell Dec 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zmeny na Autoforme tu nedokumentujeme, toto by malo byt len pre Datahub

ak tak by som to pridal priamo sem https://ekosystem.slovensko.digital/sluzby/autoform/integracny-manual#api pod novy podnadpis "Poznámky k zmenám funkcionality a štruktúry dát"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuchal

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolzbell nie, toto bolo od zaciatku myslene k vsetkym veciam. Nevidim dovod to drolit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuchal dobre ale nepridame odkaz na tieto zmeny aj sem? https://ekosystem.slovensko.digital/sluzby/autoform/integracny-manual#api

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pridajme.

<h4>Pridaný objekt <code>main_economic_activity</code></h4>
<ul>
<li>Pridaný atribút <code>code: integer</code></li>
<li>Pridaný atribút <code>name: string</code></li>
</ul>
<h4>Pridaný objekt <code>statutory_bodies</code></h4>
<ul>
<li>Štruktúra a dáta zhodné s objektom
<code>statutory</code>, ktorý je deprecated a v blízkej budúcnosti bude odstránený.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michal-rohacek toto by som preformuloval len na <h4>Pridaný objekt <code>statutory_bodies</code>, ktorého atribúty sú zhodné s objektom statutory</h4>,
a odstranenie normalne pridaj to ako dalsiu zmenu do buducna, napr. <h2 class="anchorable">Zmena k 1. 2. 2021</h2> nech sa o tom vie uz teraz

</li>
</ul>

<h2 class="anchorable">Zmena k 25. 10. 2020</h2>
<h3>Otvorené API</h3>
<h4>Zmenený endpoint <code>api/data/rpo/organizations/:id</code></h4>
Expand Down