ECO-124 Captcha na registracie #97
Conversation
| RECAPTCHA_SITE_KEY_V3=6LcNQjAbAAAAAPNGbQNxDu0RCKOFOHRdopkJ4bU4 | ||
| RECAPTCHA_SECRET_KEY_V3=6LcNQjAbAAAAAFvDD1DQJfwWVsF4npB9pI928TpU |
There was a problem hiding this comment.
Toto by sme nemali davat do public repo a ani do private repo.
There was a problem hiding this comment.
su to specialne na testing kluce, povoleny maju len localhost..... Prislo mi to praktickejsie, ako predstava, ze ked si budes najblizsie lokalne pustat projekt, budes 15 minut riesit, preco ti tam ukazuje nic nehovoriacu chybu
😆
v produkcii sa budu kluce citat z ENV samozrejme.
dame prec?
| def create | ||
| @registration ||= Registration.from(registration_params) | ||
|
|
||
| if @registration.save { validate_captcha! } |
There was a problem hiding this comment.
block sa pusti medzi validaciou fieldov (ak je nevalidny email/iny field, ani neposielame captcha request) a medzi finalnym registracnym POSTom
There was a problem hiding this comment.
Toto je velmi zvlastny pattern, ja by som skor vytiahol von ten block aj ten post do controllera.
There was a problem hiding this comment.
nechcem rypat ale
#97 (comment)
... teda, potom je save zbytocne nie?
There was a problem hiding this comment.
mozno taketo cosi jedine. ale to asi nesedi na ten tvoj pattern ktory som linkol vyssie
There was a problem hiding this comment.
No patterny su dva. bud sa to udeje v controlleri alebo v save. Ty si spravil nieco medzi co nebude fungovat ked tam ten block nedas.
There was a problem hiding this comment.
Podla mna ten druhy pattern pouzime. Nech sa to deje v controlleri.
| # redirect all /api request to to datahub.ekosystem | ||
| match '/api/(*endpoint)', to: redirect(host: 'datahub.ekosystem.slovensko.digital'), via: :all | ||
| # redirect all /api request to proper datahub.ekosystem api | ||
| match '/api/(*endpoint)', to: redirect(host: Environment.api_host), via: :all |
There was a problem hiding this comment.
Rozmyslam, ze na co toto tu vobec mame.
There was a problem hiding this comment.
napadaju ma len historicke dovody alebo zbludile requesty
este to ma nedostatky, pozri to prosimta ako hrubu stavbu, a ked to v principe schvalime, tak dorobim testy a malickosti
(napriklad
registration.finishsa mi tiez moc nelubi.. a podobne detaily)