Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Address some of the TODOs in threats and mitigation section #1123

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

lehors
Copy link
Member

@lehors lehors commented Aug 27, 2024

This patch focuses on merely editorial changes such as moving sections around and changing 'out of scope' to 'not currently addressed'.

There are a lot more TODOs to go through but that's a first step...

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 2af92a0
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/66cd94b774b2340008fe7888
😎 Deploy Preview https://deploy-preview-1123--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This patch focuses on merely editorial changes such as moving sections
around and changing 'out of scope' to 'not currently addressed'.

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Copy link
Contributor

@TomHennen TomHennen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sure wish GitHub PRs did a better job of showing moved content.

@lehors
Copy link
Member Author

lehors commented Sep 9, 2024

I sure wish GitHub PRs did a better job of showing moved content.

Well, to be fair, our setup would be quite challenging for any source control system. I should have indicated that my plan is to make all the changes to the current draft first, because that's what I expect to carry all the history. I think of the version specific folders are essentially just snapshots so I plan to just update the 1.1 folder with 1 PR when we are ready to get 1.1-CR2 out.

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@marcelamelara marcelamelara merged commit ff09015 into slsa-framework:main Sep 16, 2024
6 checks passed
zachariahcox pushed a commit to zachariahcox/slsa that referenced this pull request Oct 1, 2024
slsa-framework#1123)

This patch focuses on merely editorial changes such as moving sections
around and changing 'out of scope' to 'not currently addressed'.

There are a lot more TODOs to go through but that's a first step...

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants