Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: Fix Jekyll front matter #1124

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

lehors
Copy link
Member

@lehors lehors commented Aug 27, 2024

I noticed that the jekyll build was producing an error because the description variable in the front matter of the verifying-source.md file contained multiple lines. This fixes the format so that there is no longer any error and as a consequence the page title is now displayed correctly.

However, I must admit that although every page contains a description I cannot find whether it is actually used anywhere...

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 771eb86
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/66cd9e4ec32f530008975d5d
😎 Deploy Preview https://deploy-preview-1124--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions are used in page previews, i.e. #695.

@arewm arewm merged commit 4ce2f86 into slsa-framework:main Sep 4, 2024
6 checks passed
zachariahcox pushed a commit to zachariahcox/slsa that referenced this pull request Oct 1, 2024
I noticed that the jekyll build was producing an error because the
`description` variable in the front matter of the `verifying-source.md`
file contained multiple lines. This fixes the format so that there is no
longer any error and as a consequence the page title is now displayed
correctly.

However, I must admit that although every page contains a description I
cannot find whether it is actually used anywhere...

Signed-off-by: Arnaud J Le Hors <lehors@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants