Dev/zmq stream all ipv6 adn remove rx_zmqip #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
thattil
commented
Sep 4, 2024
•
thattil
commented
- 'Depreciated' changed to 'deprecated'
- removed rx_zmqip removed from python, API
- kept rx_zmqip command line (only in CallerSpecial to give warning)
- ZmqSocket publisher socket constructor does not take in IP anymore, uses hardcoded '0.0.0.0' instead (used in Datastreamer, in MoenchZmqProcess and slsSupportLib/tests for zmqSocket
- gui: just a read only that shows "0.0.0.0", removed signals and slots for rx_zmqip
- client: changed updateReceiverStreamingIp to updateClientStreamingIP so that the zmqip is updated with rx_hostname by default if empty
- -zmqsocket: added one more error print (ENOENT no endpoint)
… to remove all references to rx_zmqip in the next commit
…he rx_hostname ip if 0. left to do: fix command line to give warning that it will do nothing and will be removed in next release in specialcommands.
…iated' to 'deprecated' everywhere
Closed
thattil
changed the title
erikfrojdh
approved these changes
Sep 10, 2024
| case F_SET_RECEIVER_STREAMING_SRC_IP: return "F_SET_RECEIVER_STREAMING_SRC_IP"; | ||
| case F_GET_RECEIVER_STREAMING_SRC_IP: return "F_GET_RECEIVER_STREAMING_SRC_IP"; | ||
| case F_SET_RECEIVER_STREAMING_SRC_IP: return "F_SET_RECEIVER_STREAMING_SRC_IP - obsolete"; | ||
| case F_GET_RECEIVER_STREAMING_SRC_IP: return "F_GET_RECEIVER_STREAMING_SRC_IP - obsolete"; |
There was a problem hiding this comment.
Are we using this in another place? Where is obsolete defined?
There was a problem hiding this comment.
Only if you ever use verbose and print the function enum names in the tcp connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.