Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CM BYO Root tutorial #274

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Add CM BYO Root tutorial #274

merged 4 commits into from
Oct 11, 2023

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Sep 29, 2023 •
edited
Loading

  • Add Vault

@tashian tashian requested a review from a team as a code owner September 29, 2023 01:19
J-Hunter-Hawke
J-Hunter-Hawke previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@J-Hunter-Hawke J-Hunter-Hawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All a great walkthrough and good to go as-is. I especially appreciated the numerical steps and the explicit commands for the common CA techs. That said, I made a couple stylistic comments that stuck out to me

certificate-manager/byo-root.mdx Outdated Show resolved Hide resolved
certificate-manager/byo-root.mdx Outdated Show resolved Hide resolved
certificate-manager/byo-root.mdx Show resolved Hide resolved
certificate-manager/byo-root.mdx Outdated Show resolved Hide resolved
certificate-manager/byo-root.mdx Outdated Show resolved Hide resolved
certificate-manager/byo-root.mdx Outdated Show resolved Hide resolved
@tashian tashian enabled auto-merge October 11, 2023 16:14
@tashian
Copy link
Contributor Author

tashian commented Oct 11, 2023

Ok @J-Hunter-Hawke I updated this based on your review. Thanks for the feedback! Would love a 👍🏼 on this one so we can get it out there.

J-Hunter-Hawke
J-Hunter-Hawke approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@J-Hunter-Hawke J-Hunter-Hawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tashian tashian merged commit 0bbb419 into main Oct 11, 2023
2 checks passed
@tashian tashian deleted the carl/byor-tutorial branch October 11, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Hunter-Hawke J-Hunter-Hawke J-Hunter-Hawke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tashian @J-Hunter-Hawke