Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ca-kms flags to KMS examples #290

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add --ca-kms flags to KMS examples #290

merged 1 commit into from
Nov 29, 2023

Conversation

tashian
Copy link
Contributor

@tashian tashian commented Nov 29, 2023

No description provided.

@tashian tashian requested a review from a team as a code owner November 29, 2023 00:33
@tashian tashian requested a review from hslatman November 29, 2023 00:33
@tashian tashian mentioned this pull request Nov 29, 2023
Closed
@tashian tashian requested a review from maraino November 29, 2023 00:34
@tashian tashian enabled auto-merge November 29, 2023 00:35
maraino
maraino approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, an example that mixes two kms would be nice. Signing an intermediate in one kms by a root in a different one.

@tashian tashian merged commit 3296fd2 into main Nov 29, 2023
2 checks passed
@tashian tashian deleted the carl/ca-kms branch November 29, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

@hslatman hslatman Awaiting requested review from hslatman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tashian @maraino