CCIP-2645: Introducing leader lane and setting PriceReportingDisabled in Test #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
reviewed
Jul 8, 2024
anirudhwarrier
approved these changes
Jul 31, 2024
anirudhwarrier
requested changes
Jul 31, 2024
There was a problem hiding this comment.
❌PANIC❌ TestSmokeCCIPForBidirectionalLane (0.00s)
---❌ Error Found ❌---
panic: test timed out after 30m0s
Seems leader lane smoke test is failing here
anirudhwarrier
approved these changes
Aug 1, 2024
b-gopalswami
changed the title
AnieeG
reviewed
Aug 2, 2024
| @@ -80,6 +85,7 @@ type CCIPTestConfig struct { | |||
| AllNetworks map[string]blockchain.EVMNetwork | |||
| SelectedNetworks []blockchain.EVMNetwork | |||
| NetworkPairs []NetworkPair | |||
| LeaderLanes []LeaderLane | |||
There was a problem hiding this comment.
Not for this PR, for future - There are actually a lot of common set up in TestGroupInput which we can extract to common.
|
AnieeG
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces leader lane feature. Setting leader lane will avoid duplicate gas price fetch for the same destination from different source chain. Here in this PR, the expectation is to add a test where leader lane is setup and verify every commitstore report transaction hash emitted two
UsdPerUnitGasUpdatedevents.Solution
Introduce config variable to enable leader lane setup and based on network pair, automatically define set of lanes as leader and non-leader lanes, track the tx hash from the event
UsdPerUnitGasUpdatedand ensure transaction count matches to the number of sources chain selector expected.