Remove revert cases in exec race conditions #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
app-token-issuer-infra-releng
bot
requested a review
from a team
as a code owner
LCOV of commit
|
makramkd
approved these changes
Aug 1, 2024
RayXpub
approved these changes
Aug 1, 2024
# Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot
elatoskinas
approved these changes
Aug 2, 2024
|
dhaidashenko
pushed a commit
that referenced
this pull request
Sep 2, 2024
Since the separation of manual exec window and DON exec window, it would theoretically be possible that two executions happen at the same time (although unlikely). Remove reverts to ensure other msgs in the batches are unaffected --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since the separation of manual exec window and DON exec window, it would theoretically be possible that two executions happen at the same time (although unlikely).
Solution
Remove reverts to ensure other msgs in the batches are unaffected