Manual-execute-gas-overrides #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
0xsuryansh
reviewed
Aug 5, 2024
0xsuryansh
reviewed
Aug 5, 2024
…s used in execute function
added 2 commits
August 8, 2024 23:49
… CCIP-2950 gassnapshots fixes after EVM2EVMOffRamp contract enhancements
RensR
reviewed
Aug 9, 2024
| } | ||
| } | ||
|
|
||
| // CCIP-2950 create a new object for evm_2_evm_offramp.EVM2EVMOffRampGasLimitOverride |
There was a problem hiding this comment.
Is this a TODO? If so, please add TODO so it's tracked
RensR
reviewed
Aug 9, 2024
| for (uint256 i = 0; i < messages.length; ++i) { | ||
| gasLimits[i] = messages[i].gasLimit; | ||
| gasLimitOverrides[i].receiverExecutionGasLimit = messages[i].gasLimit; | ||
| //create an array for destinationGasAmounts |
There was a problem hiding this comment.
Please don't add comments that just say what the next line does without adding more information than the line would have given
elatoskinas
approved these changes
Aug 9, 2024
RayXpub
reviewed
Aug 9, 2024
…-overrides # Conflicts: # contracts/gas-snapshots/ccip.gas-snapshot # contracts/src/v0.8/ccip/offRamp/EVM2EVMOffRamp.sol # core/gethwrappers/ccip/generated/evm_2_evm_offramp/evm_2_evm_offramp.go # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
RensR
reviewed
Aug 9, 2024
| @@ -8,7 +8,7 @@ echo " └─────────────────────── | |||
|
|
|||
| SOLC_VERSION="0.8.24" | |||
| OPTIMIZE_RUNS=26000 | |||
| OPTIMIZE_RUNS_OFFRAMP=22000 | |||
makramkd
reviewed
Aug 9, 2024
| @@ -292,8 +329,11 @@ contract EVM2EVMOffRamp is IAny2EVMOffRamp, AggregateRateLimiter, ITypeAndVersio | |||
| emit SkippedAlreadyExecutedMessage(message.sequenceNumber); | |||
| continue; | |||
| } | |||
| uint32[] memory tokenGasOverrides; | |||
| bool manualExecution = manualExecGasLimits.length != 0; | |||
There was a problem hiding this comment.
Why was this moved into the loop, is it cheaper this way?
There was a problem hiding this comment.
Doesn't change much but moved outside as it saves a tiny bit
RayXpub
approved these changes
Aug 9, 2024
makramkd
approved these changes
Aug 9, 2024
0xsuryansh
approved these changes
Aug 9, 2024
|
RensR
added a commit
that referenced
this pull request
Aug 9, 2024
dhaidashenko
pushed a commit
that referenced
this pull request
Sep 2, 2024
currently, gas amounts are placed in the SourceTokenData. However, for
the multi-ramps, the token data should be chain-family agnostic, which
will likely require the destGasAmount lift to another field
- add a new Struct which holds the receiverExecutionGasLimit and
transferGasAmounts
```js
struct GasLimitOverride {
uint256 receiverExecutionGasLimit;
uint256[] tokenGasOverrides;
}
```
- `tokenGasOverrides` is an array of GasLimits to be used during the
`relaseOrMint` call for the specific tokenPool associated with token
---------
Signed-off-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com>
Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
Co-authored-by: 0xsuryansh <suryansh.shrivastava@smartcontract.com>
Co-authored-by: Rens Rooimans <github@rensrooimans.nl>
dhaidashenko
pushed a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
currently, gas amounts are placed in the SourceTokenData. However, for the multi-ramps, the token data should be chain-family agnostic, which will likely require the destGasAmount lift to another field
Solution
tokenGasOverridesis an array of GasLimits to be used during therelaseOrMintcall for the specific tokenPool associated with token