Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCI-3988] - FilteredLogs receive []Expression instead of whole KeyFilter #1403

Closed

Conversation

Farber98
Copy link
Collaborator

@Farber98 Farber98 commented Sep 2, 2024

Task Description:

Log poller Filtered logs have no use for Key, which makes the method confusing when used outside of CR

This PR:

  • Modify FilteredLogs method so it receives []query.Expression instead of whole query.KeyFilter as param.
  • Fix references.

Ticket:

Merged With:

Signed-off-by: Farber98 <juan.farber@smartcontract.com>
@Farber98 Farber98 force-pushed the BCI-3988-remove-keyfilter-from-filteredlogs branch from bbeaa07 to 4c71b24 Compare September 2, 2024 14:10
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
16.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

@Farber98 Farber98 marked this pull request as ready for review September 2, 2024 15:53
@Farber98 Farber98 requested a review from a team as a code owner September 2, 2024 15:53
Copy link
Contributor

@mateusz-sekara mateusz-sekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Farber98 we keep merging chainlink repository every 2-3 weeks so if you merge that in the upstream we will get that eventually. No need to create a PR in ccip repo unless it's super critical for CCIP to have

@Farber98 Farber98 closed this Sep 3, 2024
@mateusz-sekara mateusz-sekara deleted the BCI-3988-remove-keyfilter-from-filteredlogs branch September 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants