Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hybrid Token Pool Fixes #1483

Closed
wants to merge 9 commits into from
Closed

Hybrid Token Pool Fixes #1483

wants to merge 9 commits into from

Conversation

jhweintraub
Copy link
Contributor

@jhweintraub jhweintraub commented Oct 3, 2024 •
edited by RensR
Loading

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

LCOV of commit 11bd635 during Solidity Foundry #8628

Summary coverage rate:
  lines......: 98.0% (2295 of 2343 lines)
  functions..: 94.9% (430 of 453 functions)
  branches...: 93.8% (544 of 580 branches)

Files changed coverage rate: n/a

@RensR RensR changed the title Hybrid Token Pool Audit Fixes Hybrid Token Pool Fixes Oct 4, 2024
RensR
RensR reviewed Oct 21, 2024
View reviewed changes
contracts/gas-snapshots/automation.gas-snapshot Outdated Show resolved Hide resolved
contracts/src/v0.8/ccip/pools/USDC/HybridLockReleaseUSDCTokenPool.sol Show resolved Hide resolved
contracts/src/v0.8/ccip/test/pools/BurnMintWithLockReleaseFlagTokenPool.t.sol Outdated Show resolved Hide resolved
contracts/src/v0.8/ccip/test/pools/BurnMintWithLockReleaseFlagTokenPool.t.sol Outdated
assertEq("BurnMintTokenPool 1.5.0", s_pool.typeAndVersion());
}

function test_PoolBurn_CorrectReturnData_Success() public {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow the test naming convention by replacing PoolBurn with lockOrBurn

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment still applies, yeah?

RyanRHall
RyanRHall approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one pending comment about test names

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR left review comments

@RyanRHall RyanRHall RyanRHall approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhweintraub @RensR @RyanRHall