batch1_2024: changing berachain to not honor the finality tag due to … #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possible re-orgs at depth 1
fernandezlautaro
force-pushed
the
batch1_2024_001
branch
from
27b7857
to
2956a2b
Compare
matYang
approved these changes
Nov 8, 2024
simsonraj
approved these changes
Nov 8, 2024
matYang
pushed a commit
that referenced
this pull request
Nov 8, 2024
) ## Motivation Adding config chains for testnet (all 5) and mainnet (for 3). - B^2/Bsquared: testnet + mainnet - Berachain: testnet - BoB: testnet + mainnet - Unichain: testnet - Worldchain: testnet + mainnet - cherry picks from: - #1521 - #1522 (amend due issue with berachain in soak tests) ## Solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…possible re-orgs at depth 1
Despite berachain support finality tag they seem to have re-orgs with block depth 1, so we will rely in the finality depth of 10 which should be working all the times.
full thread: https://chainlink-core.slack.com/archives/C03ANJB9VB7/p1730998603539279
Motivation
Solution