Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optional ws url #1527

Merged
merged 16 commits into from
Nov 14, 2024
Merged

Commits on Nov 9, 2024

  1. LogBroadcaster feature flag (#14354)

    * adding feature flag for LogBroadcaster, true by default
    
    * fix test part 1
    
    * fix test
    
    * fix more test
    
    * fix test
    
    * fix test
    
    * one more
    
    * edit changeset
    
    * update changeset
    
    (cherry picked from commit bf6618d)
    huangzhen1997 authored and dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    694518d View commit details
    Browse the repository at this point in the history
  2. support new heads polling over http rpc client (#14373)

    * add functions for newHead polling
    
    * add new flag, NewHeadsPollInterval
    
    * fix test
    
    * fix test
    
    * step for adding polling new head impelmentation and sync+outOfSync loop handling logic. To add unit test
    
    * fix lint
    
    * add unit test
    
    * update changeset
    
    * update comments
    
    * simplify step 1, need to fix test
    
    * remove tests, no longer needed
    
    * fix lint
    
    * fix mock
    
    * fix simulated client
    
    * update interface
    
    * rm more
    
    * temp update for testing log level
    
    * temp update
    
    * revert modification to polygon toml
    
    * enable heap monitoring
    
    * enable for testing
    
    * revert
    
    * Dmytro's comments
    
    * make func private
    
    * fix test
    
    * add polling support for SubscribeNewHeaddocke
    
    * update log level
    
    (cherry picked from commit 5acca37)
    huangzhen1997 authored and dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    0a3cb23 View commit details
    Browse the repository at this point in the history
  3. tmp fix broken dep

    dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    7c91b65 View commit details
    Browse the repository at this point in the history
  4. fixing multinode state transition logic by register polling subscript…

    …ion in rpc client (#14534)
    
    * polling subscription to be registered
    
    * adding changeset
    
    * fix Subscribe new head
    
    * add test
    
    * update changeset
    
    * fix lint
    
    * fix deadlock and add unit test for http polling sub
    
    * update changeset
    
    * adding sub closed check and remove import
    
    * add unit test coverage for http polling subscribeToHeads
    
    * update test
    
    * address comments part 1
    
    * clean
    
    * part 2
    
    * fix lint
    
    * fix lint
    
    (cherry picked from commit de268e98b8d68a284e1260297925b91c5d2411bc)
    huangzhen1997 authored and dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    8028b5e View commit details
    Browse the repository at this point in the history
  5. WS URL can be optional when LogBroadcaster is disabled (#14364)

    * WS URL can be optional
    
    * add changeset
    
    * change
    
    * make WSURL optional
    
    * fix test, and enforce SubscribeFilterLogs to fail when ws url not provided
    
    * add comments
    
    * update changeset
    
    * update dial logic and make ws optional not required
    
    * fix test
    
    * fix
    
    * fix lint
    
    * address comments
    
    * update comments
    
    * fix test
    
    * add check when both ws and http missing
    
    * add test and add restrictions
    
    * add comment
    
    * revert outdated change
    
    * remove extra line
    
    * fix test
    
    * revert changes from rpc client
    
    * unintended change
    
    * remove unused
    
    * update verification logic
    
    * add test fix
    
    * modify unit test to cover logbroadcaster enabled false
    
    * update doc
    
    * udpate changeset
    
    * address PR comments
    
    * address pr comments
    
    * update invalid toml config
    
    * fix test
    
    * ws required for primary nodes when logbroadcaster enabled
    
    * minor
    
    * Dmytro's comments
    
    * fix nil ptr, more fix to come
    
    * fix make
    
    * refactor function sig
    
    * fix test
    
    * fix
    
    * make ws pointer
    
    * fix
    
    * fix make
    
    * address comments
    
    * fix lint
    
    * fix make
    
    * fix make
    
    * fix make
    
    * fix rpc disconnect with optional ws url
    
    ---------
    
    Co-authored-by: Dmytro Haidashenko <dmytro.haidashenko@smartcontract.com>
    (cherry picked from commit 5d96be59a27f68f2f491a7d9f8cb0b2af4e0e835)
    huangzhen1997 authored and dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    b5ee3df View commit details
    Browse the repository at this point in the history
  6. Config validation requires ws url when http polling disabled (#14929)

    * add test
    
    * add more test
    
    * add changeset
    
    (cherry picked from commit da5910eda98882f8a1b9ccc52b99afa223fb3997)
    huangzhen1997 authored and dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    9dfa696 View commit details
    Browse the repository at this point in the history
  7. Revert "tmp fix broken dep"

    This reverts commit 7c91b65.
    dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    2d049bc View commit details
    Browse the repository at this point in the history
  8. remove defaults-override as it was introduced by PR that is not inclu…

    …ded into this cherry-pick
    dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    b66b04b View commit details
    Browse the repository at this point in the history
  9. fix lint issue

    dhaidashenko committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    36815f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. disable integration-tests linter to unblock run of the tests (linter …

    …issues were not caused by the PR changes)
    dhaidashenko committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9093754 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    494fc05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acae0ac View commit details
    Browse the repository at this point in the history
  4. Revert "disable integration-tests linter to unblock run of the tests …

    …(linter issues were not caused by the PR changes)"
    
    This reverts commit 9093754.
    dhaidashenko committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9eaef36 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    61f5878 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9ba1ed8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9328fed View commit details
    Browse the repository at this point in the history