Restoring previous version of pruning (without left join) #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-sekara
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
0xAustinWang,
0xnogo and
reductionista
and removed request for
a team
Comment on lines
-509
to
-512
| // It should have retained the log matching filter0 (due to ret=0 meaning permanent retention) as well as all | ||
| // 3 logs matching filter12 (ret=1 hour). It should have deleted 3 logs not matching any filter, as well as 1 | ||
| // of the 2 logs matching filter1 (ret=1ms)--the one that doesn't also match filter12. | ||
| assert.Len(t, logs, 4) |
There was a problem hiding this comment.
I think line 512 and the comment above it are the only lines that actually need to be reverted here. The rest of the changes to this file are all useful improvements to the test that would be relevant with either version.
There was a problem hiding this comment.
Marking as approved since this doesn't matter much either way--I'll leave it up to you, if it's easier just to revert the whole thing for now and then re-apply the same commit later that's fine
reductionista
approved these changes
Nov 20, 2024
mateusz-sekara
merged commit a1636a9
into
release/2.17.0-ccip1.5
156 of 157 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Outer joins are putting too much pressure on the database. There were some fixes done to improve that, but in 2.18 release. In the meantime, I'm bringing back the previous implementation until we merge 2.18 to CCIP repo. The only difference is that, we not gonna drop the orphaned logs (it would work as the currently released version)
Using outer join
Restoring inner join