Add test for finality violation. #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
requested review from
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xnogo and
b-gopalswami
| @@ -58,3 +62,34 @@ func TestDoubleWrap(t *testing.T) { | |||
| doubleWrapped := contractreader.NewExtendedContractReader(cr) | |||
| require.Equal(t, wrapped, doubleWrapped) | |||
| } | |||
|
|
|||
| func TestFinalityViolation(t *testing.T) { | |||
There was a problem hiding this comment.
We have a dedicated task for e2e tests covering reorgs on the chainlink repo level, but can we also have more integration tests (similar to plugin_e2e_test in the chainlink-ccip) covering that part?
There was a problem hiding this comment.
I don't see why not. This test just makes sure HealthReport() is checked after IO.
asoliman92
reviewed
Jan 7, 2025
|
|
||
| func TestFinalityViolation(t *testing.T) { | ||
| cr := chainreadermocks.NewMockContractReaderFacade(t) | ||
| cr.EXPECT().HealthReport().Return(map[string]error{"farmerwolfcabbagegoat": types.ErrFinalityViolated}).Times(3) |
There was a problem hiding this comment.
"farmerwolfcabbagegoat"
hahahaah
asoliman92
approved these changes
Jan 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that the finality detection error is properly returned.
Followup to #387