pkg/loop: use beholder #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jmank88
commented
Aug 13, 2024
jmank88
commented
Aug 13, 2024
jmank88
commented
Aug 13, 2024
jmank88
commented
Aug 13, 2024
jmank88
force-pushed
the
beholder-loopp
branch
from
e27fc67 to
34df236
Compare
pkcll
reviewed
Aug 13, 2024
jmank88
force-pushed
the
beholder-loopp
branch
from
34df236 to
bdd303b
Compare
patrickhuie19
previously approved these changes
Aug 14, 2024
jmank88
force-pushed
the
beholder-loopp
branch
from
bdd303b to
8c1548c
Compare
jmank88
force-pushed
the
beholder-loopp
branch
from
8c1548c to
b73ec6b
Compare
pkcll
reviewed
Sep 6, 2024
jmank88
force-pushed
the
beholder-loopp
branch
from
4c5a556 to
24ac7ab
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
pkcll
reviewed
Sep 6, 2024
| envTelemetryInsecureConn = "CL_TELEMETRY_INSECURE_CONNECTION" | ||
| envTelemetryCACertFile = "CL_TELEMETRY_CA_CERT_FILE" | ||
| envTelemetryAttribute = "CL_TELEMETRY_ATTRIBUTE_" | ||
| envTelemetryTraceSampleRatio = "CL_TELEMETRY_TRACE_SAMPLE_RATIO" |
There was a problem hiding this comment.
Yes, if you rename env vars here then renaming beholder config fields as will be necessary as well
patrickhuie19
previously approved these changes
Sep 7, 2024
pkcll
previously approved these changes
Sep 7, 2024
jmank88
force-pushed
the
beholder-loopp
branch
from
101419b to
92f3a58
Compare
pkcll
approved these changes
Sep 9, 2024
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
patrickhuie19
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#694 introduced the beholder package. This PR is a follow up to initialize the beholder client from LOOP plugin servers.
Supports: