Skip to content

Commit

Permalink
simplify comment
Browse files Browse the repository at this point in the history
  • Loading branch information
@augustbleeds
augustbleeds committed May 16, 2024
1 parent d5fc2d3 commit 6815f5f
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions median/plugin.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,9 @@ func (p *Plugin) NewMedianFactory(ctx context.Context, provider types.MedianProv
ctxVals.SetValues(ctx)
lggr := logger.With(p.Logger, ctxVals.Args()...)

// Setting includeGasPriceSubunitsInObservation properly ensures we do not break libocr codec
// by including gasPriceSubunits in the observation when not allowed
// Once all chainlink nodes in DONs have libocr version >= fd3cab206b2c
// this check and IncludeGasPriceSubunitsInObservation field can be removed
// We may omit gas price in observation to maintain backwards compability in libocr (with older nodes).

Check failure on line 34 in median/plugin.go

View workflow job for this annotation

GitHub Actions / ci-lint 

`compability` is a misspelling of `compatibility` (misspell)
// Once all chainlink nodes have updated to libocr version >= fd3cab206b2c
// the IncludeGasPriceSubunitsInObservation field can be removed

_, isZeroDataSource := gasPriceSubunits.(*ZeroDataSource)

Expand Down

0 comments on commit 6815f5f

Please sign in to comment.