Contract Reader Multiple Address Bindings #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
0bb1539 to
82a5e8c
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
c226261 to
c5d127a
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
4 times, most recently
from
4327358 to
b505c9e
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
3 times, most recently
from
b5f1f17 to
549ae01
Compare
EasterTheBunny
changed the title
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
549ae01 to
1c245a6
Compare
EasterTheBunny
force-pushed
the
BCF-3143-multiple-address-bindings
branch
from
1c245a6 to
ab8ffa2
Compare
ilija42
requested changes
Sep 9, 2024
median/plugin.go
Outdated
Comment on lines
134
to
137
| binding := types.BoundContract{ | ||
| Address: c.contractID, | ||
| Name: contractName, | ||
| } |
There was a problem hiding this comment.
contractReaderContract should have a binding variable that is set in NewMedianFactory instead
ilija42
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.