This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
fix: set oracle admin explicitly in feedconfig oracles #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebarakos
reviewed
Aug 12, 2021
Comment on lines
+44
to
+46
| // make the pallet admin also the oracle admin | ||
| const palletAdmin = await api.query.chainlinkFeed.palletAdmin(); | ||
| feedConfig.oracles = feedConfig.oracles.map(oracle => [oracle, palletAdmin]); |
There was a problem hiding this comment.
@mattsse let's make the oracle admin same as the oracle, same as the original intention
Suggested change
| // make the pallet admin also the oracle admin | |
| const palletAdmin = await api.query.chainlinkFeed.palletAdmin(); | |
| feedConfig.oracles = feedConfig.oracles.map(oracle => [oracle, palletAdmin]); | |
| feedConfig.oracles = feedConfig.oracles.map(oracle => [oracle, oracle]); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
createFeedwas invoked with[Account]instead of[[Account, Account]]causing some tuple encoding issues so that,111111111111111111111111111111111HC1was set as the oracle's admin. This is definitely apolkadotjs/Tuplething.I fixed this by setting each of the oracle's admin to the
palletAdmin